Skip to content

phantomjs2: Fixes build with Qt5.10#33290

Merged
lukateras merged 1 commit intoNixOS:masterfrom
bkchr:phantomjs2
Jan 5, 2018
Merged

phantomjs2: Fixes build with Qt5.10#33290
lukateras merged 1 commit intoNixOS:masterfrom
bkchr:phantomjs2

Conversation

@bkchr
Copy link
Contributor

@bkchr bkchr commented Jan 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 1, 2018
@adisbladis
Copy link
Member

@GrahamcOfBorg build phantomjs2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1
shrinking /nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1/bin/.phantomjs-wrapped
stripping (with flags -S) in /nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1/bin 
patching script interpreter paths in /nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1
checking for references to /tmp/nix-build-phantomjs-2.1.1.drv-0 in /nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/yszyihf97qrjfqjqg7y7cd4sbw06d2dm-phantomjs-2.1.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1
shrinking /nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1/bin/.phantomjs-wrapped
stripping (with flags -S) in /nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1/bin
patching script interpreter paths in /nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1
checking for references to /build in /nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/jphp3d0h1s9zl4badcmnffvccsmp7lhd-phantomjs-2.1.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

flex --noline --nounistd --outfile=generated/Tokenizer_lex.cpp src/compiler/preprocessor/Tokenizer.l
bison --no-lines --skeleton=yacc.c --defines=generated/glslang_tab.h --output=generated/glslang_tab.cpp src/compiler/glslang.y
make[2]: *** [Makefile.ANGLE.DerivedSources:417: generated/glslang_tab.h] Illegal instruction: 4
make[2]: Leaving directory '/private/tmp/nix-build-qtwebkit-5.9.1.drv-0/qtwebkit-opensource-src-5.9.1/Source/ThirdParty/ANGLE'
make[1]: *** [Makefile.ANGLE:42: sub-DerivedSources-pri-make_first-ordered] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-qtwebkit-5.9.1.drv-0/qtwebkit-opensource-src-5.9.1/Source/ThirdParty/ANGLE'
make: *** [Makefile:139: sub-Source-ThirdParty-ANGLE-ANGLE-pro-make_first-ordered] Error 2
builder for ‘/nix/store/i7vvxx276ia8mf5iibkhznh660rr8f07-qtwebkit-5.9.1.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/9k3zj6388p7qs4m37hdgdbjlx7hlr9a2-phantomjs-2.1.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/9k3zj6388p7qs4m37hdgdbjlx7hlr9a2-phantomjs-2.1.1.drv’ failed

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants